Attempt to add fixing of BOMs #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Oct 5, 2020
jgowdy
force-pushed
the
byte-order-marker-fix
branch
from
3de1539 to
5a7ca4e
Compare
|
Sorry for the churn, I don't write much Python |
jgowdy
force-pushed
the
byte-order-marker-fix
branch
5 times, most recently
from
c8ef07f to
f3cee4e
Compare
|
Okay, I think this is good now. |
rohitjha
approved these changes
Oct 5, 2020
|
Would you mind adding a hacktoberfest-accepted label to this PR? I didn't make this change specifically for hacktoberfest, I need it, but I am participating in hacktoberfest. Thanks! |
|
yeah sorry I've been slow about this -- I'll take a look when I get the chance 👍 |
asottile
force-pushed
the
byte-order-marker-fix
branch
from
f3cee4e to
d18bd5b
Compare
asottile
approved these changes
Oct 11, 2020
| - id: check-byte-order-marker | ||
| name: Check for byte-order marker | ||
| description: Forbid files which have a UTF-8 byte-order marker | ||
| name: 'check BOM - deprecated: use fix-byte-order-marker' |
There was a problem hiding this comment.
I shortened the name here so it doesn't wrap -- I should probably add a test for this
| entry: file-contents-sorter | ||
| language: python | ||
| files: '^$' | ||
| - id: fix-byte-order-marker |
There was a problem hiding this comment.
I renamed this to fix-byte-order-marker so it's more clear what it does
|
|
||
| def main(argv: Optional[Sequence[str]] = None) -> int: | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument('filenames', nargs='*', help='Filenames to check') |
There was a problem hiding this comment.
I removed the --fix=no -- I'd rather have formatters-only
|
|
||
| for filename in args.filenames: | ||
| with open(filename, 'rb') as f_b: | ||
| bts = f_b.read(3) |
There was a problem hiding this comment.
there was a leaking file descriptor here, I fixed that
apricote
pushed a commit
to hetznercloud/fleeting-plugin-hetzner
that referenced
this pull request
Aug 11, 2025
… (hetznercloud/fleeting-plugin-hetzner!264) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pre-commit/pre-commit-hooks](https://github.com/pre-commit/pre-commit-hooks) | repository | major | `v5.0.0` -> `v6.0.0` | Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>pre-commit/pre-commit-hooks (pre-commit/pre-commit-hooks)</summary> ### [`v6.0.0`](https://github.com/pre-commit/pre-commit-hooks/releases/tag/v6.0.0): pre-commit-hooks v6.0.0 [Compare Source](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0) #### Fixes - `check-shebang-scripts-are-executable`: improve error message. - [#​1115](pre-commit/pre-commit-hooks#1115) MR by [@​homebysix](https://github.com/homebysix). #### Migrating - now requires python >= 3.9. - [#​1098](pre-commit/pre-commit-hooks#1098) MR by [@​asottile](https://github.com/asottile). - `file-contents-sorter`: disallow `--unique` and `--ignore-case` at the same time. - [#​1095](pre-commit/pre-commit-hooks#1095) MR by [@​nemacysts](https://github.com/nemacysts). - [#​794](pre-commit/pre-commit-hooks#794) issue by [@​teksturi](https://github.com/teksturi). - Removed `check-byte-order-marker` and `fix-encoding-pragma`. - `check-byte-order-marker`: migrate to `fix-byte-order-marker`. - `fix-encoding-pragma`: migrate to `pyupgrade`. - [#​1034](pre-commit/pre-commit-hooks#1034) MR by [@​mxr](https://github.com/mxr). - [#​1032](pre-commit/pre-commit-hooks#1032) issue by [@​mxr](https://github.com/mxr). - [#​522](pre-commit/pre-commit-hooks#522) MR by [@​jgowdy](https://github.com/jgowdy). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS42MS4xIiwidXBkYXRlZEluVmVyIjoiNDEuNjEuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm attempting to add automatic fixing of BOMs