Skip to content

Adagio: update scope params column #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2020
Merged

Adagio: update scope params column #1916

merged 1 commit into from
Apr 20, 2020

Conversation

osazos
Copy link
Contributor

@osazos osazos commented Apr 9, 2020

This PR is about updating the scope of the params environment and placement which are now required.

MartianTribe
MartianTribe reviewed Apr 17, 2020
View reviewed changes
Copy link
Collaborator

@MartianTribe MartianTribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR related to prebid/Prebid.js#5081?

@osazos
Copy link
Contributor Author

osazos commented Apr 20, 2020

@MartianTribe, no it's not.

@MartianTribe MartianTribe merged commit b31d38b into prebid:master Apr 20, 2020
@osazos osazos deleted the adagio-required-params branch May 20, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartianTribe MartianTribe MartianTribe left review comments

Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osazos @MartianTribe