Issue 49 #58
Merged
Issue 49 #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explains what to do with the bids sent to the ad server by `pbjs.enableSendAllBids()`. This is almost the same content as in `step-by-step.md`. The difference is mostly in the introduction, with a few changes to keywords here and there. The edits to `step-by-step.md` are to keep the files "diff-able" since the content is so close to a match. When we encounter a third dupe of this content, it'll be time to do the work of breaking this out into re-usable fragments. Addresses #49
Also: - Update examples template with a link - Update API reference so `pbjs.setPriceGranularity()` links to the example Addresses #50
Based on in-person conversation with @Heray
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Heray because I was sitting on an issue branch for so long I had to rebase my changes on master and it led to a strange PR with a lot of stuff.
You can see the actual doc changes at:
a2e2a4f
I've tested this locally and everything is good. Mind if we merge this in?
Normally I'd just do it but wanted to get your doc review comments on this one.