-
Notifications
You must be signed in to change notification settings - Fork 610
Revert "Fix extra padding on SelectPanel with groups" #6008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Fix extra padding on SelectPanel with groups" #6008
Conversation
This reverts commit 445b5d5.
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts the removal of bottom padding introduced in #5869, restoring previous padding behavior by removing the horizontal-inset
variant and undoing associated style changes.
- Removes
horizontal-inset
fromvariant
types and docs - Cleans up conditional logic referencing
horizontal-inset
in components - Updates CSS rules and stories to drop the
horizontal-inset
case - Deletes content from the outdated changeset (resulting in an empty file)
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/react/src/deprecated/ActionList/List.tsx | Removed horizontal-inset from the deprecated List variant union |
packages/react/src/SelectPanel/SelectPanel.tsx | Deleted the conditional variant prop that set horizontal-inset for grouped lists |
packages/react/src/ActionList/shared.ts | Removed horizontal-inset from the shared ActionListProps variant type |
packages/react/src/ActionList/Item.tsx | Updated margin and width calculations to only account for inset |
packages/react/src/ActionList/Heading.module.css | Simplified the inset selector to only target inset variant |
packages/react/src/ActionList/ActionList.stories.tsx | Removed horizontal-inset option from story controls |
packages/react/src/ActionList/ActionList.module.css | Updated CSS to drop horizontal-inset selector (see bug in brace nesting) |
packages/react/src/ActionList/ActionList.docs.json | Removed horizontal-inset from docs JSON |
.changeset/fresh-lights-wink.md | Cleared outdated changeset content |
Comments suppressed due to low confidence (2)
packages/react/src/ActionList/ActionList.module.css:15
- The closing brace for the
:where([data-variant='inset'])
rule was removed, causing the next selector block to nest incorrectly. Add a}
after this line to restore proper CSS rule separation.
padding-block: var(--base-size-8);
size-limit report 📦
|
This reverts commit b287a44.
Reverts #5869
Reverting because we succesfully removed the top padding but inadvertently removed the bottom padding, will get a new PR in soon.