Skip to content

Revert "Fix extra padding on SelectPanel with groups" #6008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

francinelucca
Copy link
Member

Reverts #5869

Reverting because we succesfully removed the top padding but inadvertently removed the bottom padding, will get a new PR in soon.

@Copilot Copilot AI review requested due to automatic review settings May 5, 2025 20:32
@francinelucca francinelucca requested review from a team as code owners May 5, 2025 20:32
Copy link

changeset-bot bot commented May 5, 2025

⚠️ No Changeset found

Latest commit: 2d8390c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label May 5, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label May 5, 2025
Copy link
Contributor

github-actions bot commented May 5, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the removal of bottom padding introduced in #5869, restoring previous padding behavior by removing the horizontal-inset variant and undoing associated style changes.

  • Removes horizontal-inset from variant types and docs
  • Cleans up conditional logic referencing horizontal-inset in components
  • Updates CSS rules and stories to drop the horizontal-inset case
  • Deletes content from the outdated changeset (resulting in an empty file)

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react/src/deprecated/ActionList/List.tsx Removed horizontal-inset from the deprecated List variant union
packages/react/src/SelectPanel/SelectPanel.tsx Deleted the conditional variant prop that set horizontal-inset for grouped lists
packages/react/src/ActionList/shared.ts Removed horizontal-inset from the shared ActionListProps variant type
packages/react/src/ActionList/Item.tsx Updated margin and width calculations to only account for inset
packages/react/src/ActionList/Heading.module.css Simplified the inset selector to only target inset variant
packages/react/src/ActionList/ActionList.stories.tsx Removed horizontal-inset option from story controls
packages/react/src/ActionList/ActionList.module.css Updated CSS to drop horizontal-inset selector (see bug in brace nesting)
packages/react/src/ActionList/ActionList.docs.json Removed horizontal-inset from docs JSON
.changeset/fresh-lights-wink.md Cleared outdated changeset content
Comments suppressed due to low confidence (2)

packages/react/src/ActionList/ActionList.module.css:15

  • The closing brace for the :where([data-variant='inset']) rule was removed, causing the next selector block to nest incorrectly. Add a } after this line to restore proper CSS rule separation.
padding-block: var(--base-size-8);

Copy link
Contributor

github-actions bot commented May 5, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.92 KB (-0.03% 🔽)
packages/react/dist/browser.umd.js 99.23 KB (+0.16% 🔺)

@francinelucca francinelucca merged commit b287a44 into main May 5, 2025
49 checks passed
@francinelucca francinelucca deleted the revert-5869-hectahertz/fix-padding-selectpanel-groups branch May 5, 2025 20:51
francinelucca added a commit that referenced this pull request May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants