Skip to content

reminify p5.js #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

reminify p5.js #1

wants to merge 1 commit into from

Conversation

mwcz
Copy link

@mwcz mwcz commented Sep 22, 2015

I was seeing something strange where using p5.js worked fine, and p5.min.js also worked but threw an error, "p5 is not defined". I traced it to the p5.prototype._validateParameters function being declared twice, the second time to disable it. But in the minified file, it was declared only once, but it seemed to be outside of the scope of where "p5" is defined.

I searched https://raw.githubusercontent.com/lmccart/p5.js-release/master/lib/p5.min.js for "p5.prototype._validateParameters" and thought it was weird how the function is a noop, whereas in p5.js it is defined once, then overridden, but even the overridden version returns true.

I ran uglifyjs p5.js -c -m -o p5.min.js for this PR and it resolved the error for me. Lemme know if I did anything wrong or telling me to buzz off is fine too. :D

@mwcz
Copy link
Author

mwcz commented Sep 22, 2015

Then again maybe submitting PRs on a release repo doesn't make sense! :)

@lmccart lmccart closed this Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants