Fix duplicate p5.js init by checking window.p5 and skipping if alread… #7791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

VANSH3104 wants to merge 1 commit into processing:dev-2.0 from VANSH3104:VANSH3104/Duplicate

Contributor

VANSH3104 commented May 6, 2025

…y loaded

Resolves #7687

Changes:

Add check for window.p5 instanceof p5 before global binding
Skip initialization and warn if p5.js was already loaded
Avoids errors from Object.defineProperty redefinition
Fixes issue where multiple p5.js imports cause failures

Screenshots of the change:

PR Checklist

[x ] npm run lint passes
Inline reference is included / updated
Unit tests are included / updated


          Fix duplicate p5.js init by checking window.p5 and skipping if alread…

52bd064

…y loaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet