Brightness example: Fix maximum value for brightness #777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The colors in the color brightness example always seem to be rather dark. Even when moving the cursor to the lowest position possible.
Reason
The maximum value for brightness is being set to the
width
of the canvas. AsmouseY
is being used as the brightness of the color and the height of the canvas is much lower than the width, it is impossible to reach full brightness for a bar.Fix
This can be fixed by setting the maximum value for brightness to the
height
of the canvas.