Skip to content

Add Rosetta Code example set #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2019

Conversation

jeremydouglass
Copy link
Contributor

Adds the PDE Processing Rosetta Code example set to Contributions Manager.
https://github.com/jeremydouglass/processing_rosetta_examples

@REAS REAS merged commit c8309ce into processing:master Dec 14, 2019
@jeremydouglass
Copy link
Contributor Author

Hmm. Odd.

In PDE > Contrib > Examples > Rosetta Code > Install,

I'm getting the error "Could not find a examples in the downloaded file".

Odd, because when I take the URL in sources.conf, change .txt to .zip, and download that file and unzip, there is clearly an "examples" sub folder.

https://github.com/jeremydouglass/processing_rosetta_examples/releases/latest/download/processing_rosetta_examples.zip

And when I check a comparable example set -- like https://shiffman.net/p5/examples/natureofcode.txt -- the corresponding .zip has an examples folder and the same files, in the same way. I'm not sure what is causing this error....

@REAS
Copy link
Member

REAS commented Dec 15, 2019

@prisonerjohn Can you have a look at this?

@REAS
Copy link
Member

REAS commented Dec 15, 2019

I also received the "Could not find examples in the downloaded file" error message. I was able to download the ZIP through a browser and then to unZIP it. After I manually placed it into the Examples folder, the examples behaved as expected.

prisonerjohn added a commit that referenced this pull request Dec 15, 2019
…setta-code"

This reverts commit c8309ce, reversing
changes made to 5cdce6a.
@jeremydouglass
Copy link
Contributor Author

@REAS thanks -- it looks like the zip was built by my release script such that it lacked a top-level folder. My MacOS Finder unzip automatically creates a top-level folder matching the zip file name if there is not one, so this problem wasn't apparent to either of us when inspecting and manually installing the file that way.

@prisonerjohn pointed this out (thanks!) and requested a name change, so I have submitted a new URL to a renamed repo https://github.com/jeremydouglass/rosetta_examples_p5/releases/latest/download/rosetta_examples_p5.txt via email and prisonerjohn will commit to sources.conf.

@prisonerjohn
Copy link
Member

Should be good to go now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants