Skip to content

Sound Tutorial - ex3-6 link sketches w/required MP3s, closes #714 #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

jeremydouglass
Copy link
Contributor

Link to tutorial sketches to related examples sketches that contain required mp3s.

@jeremydouglass
Copy link
Contributor Author

jeremydouglass commented Jun 4, 2020

...note however that the sketches aren't identical anymore (between the tutorial and the PDE examples folder, the code contents are now different in some cases). It looks like perhaps the example sketches were updated / evolved over time, but the tutorial ones did not. So it is possible that this should be amended by making the tutorial better aligned to the new examples ... or that should be a separate issue / PR.

@REAS REAS merged commit c2d1fee into processing:master Jun 4, 2020
@REAS
Copy link
Member

REAS commented Jun 4, 2020

Aligning the Sound examples is a welcome PR. I'm checking them out right now to see which is the most updated.

@REAS
Copy link
Member

REAS commented Jun 4, 2020

I looks like the text added through this PR mangled the comments. I am making this change right now and I'll update it. Thank you for catching these things and making the PR!

/**
 * Processing Sound Library, Example 3
 * 
 * This example shows how to make a simple sampler and sequencer 
 * with the Sound library. In this sketch, five different samples are 
 * loaded and played back at different pitches, in this case five 
 * different octaves. The sequencer triggers an event every 200-1000 
 * milliseconds randomly. Each time a sound is played a colored 
 * rect with a random color is displayed.
 * 
 Load this example with included MP3s from: 
   Examples > Libraries > Sound > Soundfile > Sampler 
 */

@jeremydouglass
Copy link
Contributor Author

Sorry, I shouldn't have opened the PR until I finished running my test build. Hope you saw the note about sketch alignment as well -- I can make that a separate issue later since this is being merged now.

@REAS
Copy link
Member

REAS commented Jun 4, 2020

I think it's finished now with example alignment and correcting the comments. I'm re-building the tutorial and checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants