Skip to content

Backport MessageContext parser from fluent 0.6.2 #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2018

Conversation

stasm
Copy link
Contributor

@stasm stasm commented Feb 8, 2018

  - Correctly parse empty comment lines. (projectfluent#149)
  - Forbid null attribute and variant values. (part of projectfluent#150)
@stasm
Copy link
Contributor Author

stasm commented Feb 8, 2018

In order to test the new runtime parser I had to update the fixtures of the tooling parser in fluent-syntax. I don't think updating the tooling parser to 0.6.x is worth the effort so instead, I simply generated the expected parse results from these updated fixtures using the 0.4.x fluent-syntax parser. To some extent this codifies how the parsing behavior changed between 0.4.x and 0.6.x. I'm not sure if there's a better way to handle these test updates.

@stasm stasm requested a review from zbraniecki February 8, 2018 17:26
@stasm stasm merged commit d0e6dd8 into projectfluent:[email protected] Feb 9, 2018
@stasm stasm deleted the backport-0.6.2 branch February 9, 2018 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants