Skip to content

Nested children support in overlays #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Nested children support in overlays #521

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b73ae7
(@fluent-react) Fix ignore-nested-children test
joepie91 Dec 13, 2020
8364022
(@fluent/react) Process nested children
joepie91 Dec 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
(@fluent-react) Fix ignore-nested-children test
  • Loading branch information
@joepie91
joepie91 committed Dec 13, 2020
commit 3b73ae74a359b545509d8c515547525f82210cc5
5 changes: 4 additions & 1 deletion fluent-react/test/localized_overlay.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,10 @@ foo = Click <button><em>me</em></button>!

const renderer = TestRenderer.create(
<LocalizationProvider l10n={new ReactLocalization([bundle])}>
<Localized id="foo" elems={{button: <button onClick={alert}></button>}}>
<Localized id="foo" elems={{
button: <button onClick={alert}></button>,
em: <em></em>
}}>
<div />
</Localized>
</LocalizationProvider>
Expand Down