Skip to content

Add getFragment method to ReactLocalization #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Oct 27, 2022
Merged

Add getFragment method to ReactLocalization #595

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
04bb1a0
Add getFragment method to ReactLocalization
Vinnl Jul 9, 2022
cdf5ea9
Add getElement, redefine getFragment using it
Vinnl Sep 1, 2022
695874d
Re-define <Localized> using getElement
Vinnl Sep 1, 2022
435a08b
fixup! Add getElement, redefine getFragment using it
Vinnl Sep 8, 2022
29be3dd
Mark all empty ID values as invalid
Vinnl Sep 8, 2022
ab17fdb
fixup! Add getElement, redefine getFragment using it
Vinnl Sep 8, 2022
a9b73ca
Use a Map for a record
Vinnl Sep 8, 2022
87c73d4
Desructure a parameter
Vinnl Sep 8, 2022
515918e
fixup! Use a Map for a record
Vinnl Sep 12, 2022
6027f43
Remove getFragment
Vinnl Sep 12, 2022
f2b728c
Rename second `getString` parameter to `vars`
Vinnl Sep 12, 2022
998e786
fixup! Add getElement, redefine getFragment using it
Vinnl Sep 12, 2022
b950f1c
Filter out invalid elems on the first pass
Vinnl Sep 12, 2022
59671cc
Only accept single element to render in getElement
Vinnl Sep 12, 2022
71dfc62
Outsource one-element checking to Children.only
Vinnl Oct 27, 2022
dc130a5
Empty-initialise unused parameter
Vinnl Oct 27, 2022
dbfbdb5
Clarify variable name
Vinnl Oct 27, 2022
8362f23
Apply Prettier code styling
eemeli Oct 27, 2022
dcf65c3
Revert React.Children.only use, rename componentToRender -> source in…
eemeli Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mark all empty ID values as invalid 
As per
#595 (comment)
  • Loading branch information
@Vinnl
Vinnl committed Sep 8, 2022
commit 29be3ddfa264ca4bd1c5d7c43fb86e35c832b620
2 changes: 1 addition & 1 deletion fluent-react/src/localization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ export class ReactLocalization {

const bundle = this.getBundle(id);
if (bundle === null) {
if (id === undefined) {
if (!id) {
this.reportError(
new Error("No string id was provided when localizing a component.")
);
Expand Down