Skip to content

Update dependencies & fluent-react/example #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

eemeli
Copy link
Member

@eemeli eemeli commented Mar 22, 2023

Fixes #610, as the fluent-react peerDependency condition was indeed too strict.

With modern npm, we don't need to use file: paths for internal dependencies and can also drop support of npm<7 in the lockfile.

@eemeli eemeli requested a review from gregtatum March 22, 2023 13:05
Copy link
Member

@gregtatum gregtatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all seems reasonable!

@eemeli eemeli merged commit 36a895b into projectfluent:master Mar 24, 2023
@eemeli eemeli deleted the update-deps branch March 24, 2023 05:59
@Vinnl
Copy link
Contributor

Vinnl commented Mar 27, 2023

Thanks for this! Could this also be released as a new version?

dj-sf pushed a commit to djsf-kobayashi/penny that referenced this pull request Sep 30, 2023
@fluent/react lists 0.17 as the latest compatible version of
@fluent/bundle. A fix has been merged, but not released yet:
projectfluent/fluent.js#612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@fluent/react marks @fluent/bundle as incompatible
3 participants