Forbid tabs as inline blanks #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasm
commented
Aug 17, 2018
| # Partial Error (tab is not a valid indent) | ||
| key04 = | ||
| This line is indented by 4 spaces, | ||
| whereas this line by 1 tab. |
There was a problem hiding this comment.
This exhibits the same behavior as when a broken attribute is encountered. The body of the message up until the syntax error parses fine. Essentially, it's the same situation as:
key04 =
This line is indented by 4 spaces,
junk here
Pike
suggested changes
Aug 17, 2018
test/fixtures/tab.ftl
Outdated
| @@ -0,0 +1,14 @@ | |||
| # Error (tab after =) | |||
| key01 = Value 01 | |||
There was a problem hiding this comment.
I think this should be a success.
There was a problem hiding this comment.
Should the tab be trimmed from the value or kept verbatim?
There was a problem hiding this comment.
I guess it makes sense to only trim syntax whitespace. I'd keep it.
test/fixtures/tab.ftl
Outdated
| key01 = Value 01 | ||
|
|
||
| # Error (tab before =) | ||
| key02 = Value 02 |
There was a problem hiding this comment.
This failing is right, as are the ones below.
|
Thanks, @Pike. I made the tab character a |
Pike
approved these changes
Aug 20, 2018
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #165.