Skip to content

Move Visitor and Transformer out of ast.py #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stasm opened this issue May 14, 2020 · 2 comments
Closed

Move Visitor and Transformer out of ast.py #141

stasm opened this issue May 14, 2020 · 2 comments

Comments

@stasm
Copy link
Contributor

stasm commented May 14, 2020

I'd like to consider making ast.py strictly about AST nodes. The processing classes could be moved to another module: tools.py, visitor.py, process.py or something else.
@stasm stasm mentioned this issue May 14, 2020
Merged
@Pike
Copy link
Contributor

Pike commented May 14, 2020

I briefly glanced at this, and then recognized that this is a breaking API change. Currently, consumers import them from ast, and if we tried to continue to expose them there, stuff would break :-(.

But yeah, we can do this in a new release of fluent.syntax.

@stasm
Copy link
Contributor Author

stasm commented May 14, 2020

Yep, that's why I filed a new issue about this, to discuss this independently of #139.

Pike added a commit to Pike/python-fluent that referenced this issue May 20, 2020
@Pike
Externalize Visitor/Transformer from ast to visitor (projectfluent#141)…
c31e79a 
…, add docs

`fluent.syntax.visitor` is matching what `@fluent/syntax` does.
The documentation covers more than just Visitor/Transformer, but
now is as good a time as any to add that.
Pike added a commit to Pike/python-fluent that referenced this issue May 20, 2020
@Pike
Externalize Visitor/Transformer from ast to visitor (projectfluent#141)…
6269f37 
…, add docs

`fluent.syntax.visitor` is matching what `@fluent/syntax` does.
The documentation covers more than just Visitor/Transformer, but
now is as good a time as any to add that.
Pike added a commit that referenced this issue May 20, 2020
@Pike
Externalize Visitor/Transformer from ast to visitor (#141), add docs
3866f76 
`fluent.syntax.visitor` is matching what `@fluent/syntax` does.
The documentation covers more than just Visitor/Transformer, but
now is as good a time as any to add that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Pike @stasm @zbraniecki