Fix blocker jsdoc bugs #1777
Closed
Fix blocker jsdoc bugs #1777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buu700
added a commit
to buu700/protobufjs-cli-tmp
that referenced
this pull request
Jul 19, 2022
buu700
added a commit
to buu700/protobufjs-cli-tmp
that referenced
this pull request
Jul 19, 2022
Contributor
|
Do you think we could leave the fix in |
Author
|
I'm not really sure. This is the fix that worked for me, but I'm not familiar enough with protobufjs or jsdoc to say what it would take to work around the issue without pinning. This has been broken for several years now, but the jsdoc team hasn't been responding to the issue I'd submitted (jsdoc/jsdoc#1644). |
Author
|
Closed because it's superseded by #1844. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are major happy path bugs that have been in the stable release for a number of years now. The root cause seems to be on jsdoc's end, but the ticket remains unaddressed.
At this point, I think it makes sense to just stick with 3.5.5 indefinitely, at least until jsdoc is fixed and updated to provide a cleaner interface.