Deprecate Descriptor Label. As an alternative, add helper methods for checking whether a field is required or repeated. #20687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_736676374
branch
6 times, most recently
from
c452f0f to
26634c7
Compare
… checking whether a field is required or repeated. This is for C++, Java, and Python. PiperOrigin-RevId: 740152256
copybara-service
bot
force-pushed
the
test_736676374
branch
from
26634c7 to
5bd7d02
Compare
thomasvl
added a commit
to thomasvl/swift-protobuf
that referenced
this pull request
Mar 25, 2025
This is the start of tracking the upstream changes to move away from Label and the "optional" bit in there. See protocolbuffers/protobuf#20687 for the start of it. Update the comments on isRequired and isRepeated also.
thomasvl
added a commit
to apple/swift-protobuf
that referenced
this pull request
Mar 25, 2025
This is the start of tracking the upstream changes to move away from Label and the "optional" bit in there. See protocolbuffers/protobuf#20687 for the start of it. Update the comments on isRequired and isRepeated also.
thomasvl
added a commit
to thomasvl/swift-protobuf
that referenced
this pull request
Mar 25, 2025
Continues tracking changes in protocolbuffers/protobuf#20687.
thomasvl
added a commit
to apple/swift-protobuf
that referenced
this pull request
Mar 25, 2025
Continues tracking changes in protocolbuffers/protobuf#20687.
thomasvl
added a commit
to thomasvl/swift-protobuf
that referenced
this pull request
Mar 25, 2025
Add a second storage that can be used to avoid deprecation warnings from the code within the file that does have to touch/inspect the value. Finishes up tracking changes in protocolbuffers/protobuf#20687.
thomasvl
added a commit
to thomasvl/swift-protobuf
that referenced
this pull request
Mar 25, 2025
Add a second storage that can be used to avoid deprecation warnings from the code within the file that does have to touch/inspect the value. Finishes up tracking changes in protocolbuffers/protobuf#20687.
thomasvl
added a commit
to apple/swift-protobuf
that referenced
this pull request
Mar 25, 2025
Add a second storage that can be used to avoid deprecation warnings from the code within the file that does have to touch/inspect the value. Finishes up tracking changes in protocolbuffers/protobuf#20687.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate Descriptor Label. As an alternative, add helper methods for checking whether a field is required or repeated.
This is for C++, Java, and Python.