Skip to content

Implement wasi.environ_{get,sizes_get}. #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Feb 24, 2021
Merged

Implement wasi.environ_{get,sizes_get}. #126

merged 20 commits into from
Feb 24, 2021

Conversation

mathetake
Copy link
Contributor

@mathetake mathetake commented Feb 8, 2021 •
edited
Loading

Signed-off-by: Takeshi Yoneda [email protected]

ref envoyproxy/envoy#14958

@mathetake
impl Env vars
0ab19fc 
Signed-off-by: Takeshi Yoneda <[email protected]>
@PiotrSikora PiotrSikora mentioned this pull request Feb 8, 2021
Closed
@mathetake mathetake marked this pull request as ready for review February 9, 2021 02:17
@mathetake
Add test case
c645ffd 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Fix test case
65c543d 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Use unordered_map
2a553a2 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Initialize envs_ on child VMs
2065bd5 
Signed-off-by: Takeshi Yoneda <[email protected]>
This was referenced Feb 10, 2021
Closed
Open
PiotrSikora
PiotrSikora reviewed Feb 19, 2021
View reviewed changes
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, left a few comments.

@mathetake
Merge remote-tracking branch 'origin/master' into env-vars
f06a405
@mathetake
Review: fix nits
03da0e1 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Fix size
2453530 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Fix build error
e0524c1 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Add getWordSize member
f8fd45b 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Use stdint
3b0dae6 
Signed-off-by: Takeshi Yoneda <[email protected]>
PiotrSikora
PiotrSikora reviewed Feb 24, 2021
View reviewed changes
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sans style nits.

@mathetake
review: fix style
64e94c7 
Signed-off-by: Takeshi Yoneda <[email protected]>
PiotrSikora
PiotrSikora reviewed Feb 24, 2021
View reviewed changes
@mathetake
Remove unnecessary include
31dabdc 
Signed-off-by: Takeshi Yoneda <[email protected]>
PiotrSikora
PiotrSikora reviewed Feb 24, 2021
View reviewed changes
@mathetake
Fix style
70c2872 
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake
Use string::append consistently
c5c4d2d 
Signed-off-by: Takeshi Yoneda <[email protected]>
PiotrSikora
PiotrSikora approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mathetake
Copy link
Contributor Author

Thanks for the review all the time! I'm going to merge by myself 👍

@mathetake mathetake merged commit 5ea92c8 into proxy-wasm:master Feb 24, 2021
@mathetake mathetake deleted the env-vars branch February 24, 2021 11:05
@mathetake mathetake mentioned this pull request Mar 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrSikora PiotrSikora PiotrSikora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathetake @PiotrSikora