Enable onForeignFunction and proxy-specific extensions to the ABI. #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Plevyak <[email protected]>
Signed-off-by: John Plevyak <[email protected]>
PiotrSikora
approved these changes
Jun 1, 2020
| @@ -473,6 +477,8 @@ class Context : public ContextBase { | |||
| // Returns nullptr if the Context no longer exists (i.e. the stream has been | |||
| // destroyed). | |||
| Context *getContext(uint32_t context_id); | |||
| RootContext *getRootContext(uint32_t context_id); | |||
| ContextBase *getContextBase(uint32_t context_id); | |||
There was a problem hiding this comment.
The getContextBase function is required in order to implement the new EnvoyWasmVmIntegration::getNullVmFunction function in the envoy-wasm changes in order to support envoy_XXXX specific extensions to the ABI.
There was a problem hiding this comment.
getRootContext was added for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Plevyak [email protected]