Pass end_of_stream to header callbacks. #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the same end_of_stream flag to the on_request_headers and on_response_headers callbacks that Envoy makes for non-WASM filters. This way it is possible to write a filter that can operate on the request or response body but still be resilient if no body is present. Signed-off-by: Gregory Brail <[email protected]>
jplevyak
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the same end_of_stream flag to the on_request_headers
and on_response_headers callbacks that Envoy makes for non-WASM filters.
This way it is possible to write a filter that can operate on the
request or response body but still be resilient if no body is present.
This is an incompatible change -- WASM filters will need to be rebuilt with the additional flag on the proxy_on_request_headers and proxy_on_response_headers flags added.
I'll submit the matching PRs for the other two repos once this one is merged.
Signed-off-by: Gregory Brail [email protected]