test(fix): fix hanhing mocha tests

Fix message actions and ReactNative tests which lead mocha to freeze.

.travis.yml

@@ -15,6 +15,11 @@ addons:
 
 stages:
   - name: "test"
+    if: |
+      type != pull_request
+  - name: "test pr branch"
+    if: |
+      type == pull_request
 
 jobs:
   include:
@@ -28,3 +33,7 @@ jobs:
     - name: 'NodeJS 12'
       node_js: '12'
       script: gulp test
+    - stage: "test pr branch"
+      name: 'NodeJS 12'
+      node_js: '12'
+      script: gulp test

test/dist/objectsv2.test.js

@@ -139,4 +139,4 @@ describe('Objects V2 system tests', () => {
     expect(result.status).to.equal(200);
     expect(result.data).to.be.null;
   });
-});
+});

test/dist/react-native.test.js

@@ -1,57 +1,59 @@
 import fetch from 'node-fetch';
 import { expect } from 'chai';
 import PubNub from '../../src/react_native';
+import nock from "nock";
 
 global.fetch = fetch;
 
 let pubnub;
 
-let listener = null;
-
 let channelSuffix = new Date().getTime() + (Math.random());
 
 let myChannel1 = `mychannel1${channelSuffix}`;
 let myChannel2 = `mychannel2${channelSuffix}`;
 // let myChanneGroup1 = `myChannelGroup1${channelSuffix}`;
 
 describe('#distribution test (rkt-native)', function () {
+  after(function () {
+    pubnub.destroy();
+  });
 
-  before(function () {
+  beforeEach(() => {
     pubnub = new PubNub({ subscribeKey: 'demo', publishKey: 'demo' });
   });
 
-  after(function () {
-    pubnub.destroy();
+  afterEach(() => {
+    pubnub.removeAllListeners();
+    pubnub.unsubscribeAll();
+    pubnub.stop();
   });
 
   it('should have to subscribe a channel', (done) => {
-    listener = {
+    pubnub.addListener({
       status: (st) => {
         expect(st.operation).to.be.equal('PNSubscribeOperation');
+        pubnub.unsubscribeAll()
         done();
       }
-    };
-
-    pubnub.addListener(listener);
+    });
     pubnub.subscribe({channels: [myChannel1]});
   });
 
   it('should have to receive message from a channel', (done) => {
-    pubnub.disconnect();
-    pubnub.removeListener(listener);
-    pubnub.reconnect();
-
-    listener = {
+    pubnub.addListener({
+      status: (st) => {
+        if (st.operation === 'PNSubscribeOperation') {
+          pubnub.publish({ channel: myChannel2, message: { text: 'hello React-Native SDK' }});
+        }
+      },
       message: (m) => {
         expect(m.channel).to.be.equal(myChannel2);
         expect(m.message.text).to.be.equal('hello React-Native SDK');
+        pubnub.unsubscribeAll()
         done();
       }
-    };
-
-    pubnub.addListener(listener);
+    });
     pubnub.subscribe({channels: [myChannel2]});
-    pubnub.publish({ channel: myChannel2, message: { text: 'hello React-Native SDK' }});
   });
 
   it('should have to set state', (done) => {
@@ -120,24 +122,26 @@ describe('#distribution test (rkt-native)', function () {
     done();
   });
 
+  // TODO: fix test. it shouldn't rely on previous steps outcome.
   it('should have to unsubscribe', function (done) {
-    pubnub.disconnect();
-    pubnub.removeListener(listener);
-    pubnub.reconnect();
-
     let finished = false;
 
     pubnub.addListener({
       status: function (st) {
-        expect(st.operation).to.be.equal('PNUnsubscribeOperation');
-
-        if (!finished) {
-          // prevent calling done twice
-          finished = true;
-          done();
+        if (st.operation === 'PNSubscribeOperation') {
+          pubnub.unsubscribe({channels: [myChannel1]});
+        } else {
+          expect(st.operation).to.be.equal('PNUnsubscribeOperation');
+
+          if (!finished) {
+            // prevent calling done twice
+            finished = true;
+            pubnub.unsubscribeAll()
+            done();
+          }
         }
       }
     });
-    pubnub.unsubscribe({channels: [myChannel1]});
+    pubnub.subscribe({channels: [myChannel1]});
   });
-});
+});

test/integration/endpoints/message_actions.test.js

@@ -340,6 +340,7 @@ describe('message actions endpoints', () => {
           assert.equal(messageActionEvent.data.messageTimetoken, messageTimetoken);
           assert(messageActionEvent.data.actionTimetoken);
           assert.equal(messageActionEvent.event, 'added');
+          pubnub.unsubscribeAll()
 
           done();
         }
@@ -489,6 +490,7 @@ describe('message actions endpoints', () => {
               assert.equal(messageActionEvent.data.messageTimetoken, messageTimetokens[0]);
               assert.equal(messageActionEvent.data.actionTimetoken, actionTimetokens[0]);
               assert.equal(messageActionEvent.event, 'removed');
+              pubnub.unsubscribeAll()
 
               done();
             }