Skip to content

Conversation

dirien
Copy link
Contributor

@dirien dirien commented Sep 25, 2025

Proposed changes

Unreleased product version (optional)

Related issues (optional)

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@dirien dirien force-pushed the day-2-operations-drift-detection-and-remediation branch from 950b460 to 33e772c Compare October 7, 2025 15:37
@pulumi-bot
Copy link
Collaborator

@dirien dirien marked this pull request as ready for review October 9, 2025 21:02
Copy link
Contributor

claude bot commented Oct 9, 2025

Review Feedback

Thank you for this comprehensive blog post on drift detection and remediation. The content is well-structured and provides valuable insights for platform engineers. Below are some issues that need to be addressed:

Critical Issues

1. Incorrect documentation link (Line 94)

  • Issue: The CrossGuard link is incorrect
  • Current: CrossGuard policies
  • Should be: CrossGuard policies
  • The path /docs/iac/packages-and-automation/crossguard does not exist in the documentation structure.

2. Broken/incomplete documentation link (Line 176)

  • Issue: The Deployment Settings link points to a non-existent page
  • Current: Deployment Settings
  • Should be: Deployment Settings OR a more specific page if one exists for deployment settings
  • The get-started page does not exist in the deployments directory.

3. Ambiguous documentation link (Line 301)

  • Issue: Duplicate reference to Pulumi Deployments with different link text
  • Current: Pulumi Deployments
  • Should be: Pulumi Deployments
  • This maintains consistency with the other references and points to the correct landing page.

Style and Content Suggestions

4. Generic image names (Multiple files)

  • Issue: Image files are named generically (img.png, img_1.png, img_2.png, etc.)
  • Recommendation: Use descriptive names for better maintainability:
    • img.png to deployment-settings-source-control.png
    • img_1.png to drift-detection-schedule.png
    • img_2.png to auto-remediation-toggle.png
    • img_3.png to webhook-configuration.png
    • img_4.png appears unused in the markdown - confirm if needed

5. Inconsistent terminology (Line 31)

  • The social media description uses day 2 operations (lowercase) while the title uses Day 2 Operations (title case)
  • Recommendation: Ensure consistency with title casing

6. Long paragraphs throughout

  • Several paragraphs exceed the recommended 3-4 sentences for blog readability
  • Examples: Lines 61-65, 79-86, 204-209
  • Recommendation: Break these into shorter paragraphs for better readability, especially for the online format

7. Future date in frontmatter (Line 6)

  • Current: date: 2025-10-10
  • This is a future date (October 10, 2025 vs. current date October 9, 2025)
  • Recommendation: Verify if this is intentional for scheduled publishing or should be today's date

Positive Aspects

  • Strong narrative structure with relatable scenarios
  • Clear technical explanations of drift detection concepts
  • Well-integrated code examples
  • Good use of the three-step workflow explanation
  • Effective CTAs and links to related series content
  • File properly ends with a newline
  • Social media content is well-crafted for both Twitter and LinkedIn

Action Items

  1. Fix the three broken/incorrect documentation links
  2. Consider renaming image files for better maintainability
  3. Verify the publish date is correct
  4. Consider breaking up longer paragraphs for improved readability

The content quality is excellent overall. Once the broken links are fixed, this will be a valuable addition to the IDP Best Practices series.

@pulumi-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants