Skip to content

Boolean vs String for dm_use_deferred_removal / dm_use_deferred_deletion #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
esalberg opened this issue Feb 5, 2018 · 4 comments
Closed
Assignees
Milestone

Comments

@esalberg
Copy link
Contributor

esalberg commented Feb 5, 2018

Please see the comments on this PR:
#99

The typing for dm_use_deferred_removal and dm_use_deferred_deletion was set to String, whereas we had assumed previously that those were Booleans (due to having true/false as options). I'm assuming the String type was used because the defaults were set to undef (probably should have been false).

Is the String type desired, in which case we'll have to update our settings to quote true/false (which requires a Lint override), or was this an oversight and they should be set to Boolean?

@sheenaajay
Copy link
Contributor

thanks @esalberg @dol for valuable comment.Will get the fix soon for the following variables and update the spec tests accordingly.

@sheenaajay
Copy link
Contributor

Thank you.The PR is ready with the fix #145

@sheenaajay
Copy link
Contributor

dm_use_deferred_removal and dm_use_deferred_deletion use the data type Boolean in this PR

davejrt added a commit that referenced this issue Feb 7, 2018
@davejrt
Copy link
Contributor

davejrt commented Feb 8, 2018

fixed in PR #145

@davejrt davejrt closed this as completed Feb 8, 2018
@davejrt davejrt added this to the v1.1.0 milestone Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants