Skip to content

docker facts fail if docker is not running #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vchepkov opened this issue Feb 11, 2019 · 1 comment
Closed

docker facts fail if docker is not running #422

vchepkov opened this issue Feb 11, 2019 · 1 comment
Milestone

Comments

@vchepkov
Copy link
Contributor

If docker is installed on a node, but is not running, puppet throughs exceptions during fact collection:

Error: Facter: error while resolving custom fact "docker": 751: unexpected token at ''
Error: Facter: error while resolving custom fact "docker_server_version": undefined method `[]' for nil:NilClass
$ puppet --version
5.5.10

$ docker version
Client:
 Version:      17.05.0-ce
 API version:  1.29
 Go version:   go1.7.5
 Git commit:   89658be
 Built:        Thu May  4 22:06:25 2017
 OS/Arch:      linux/amd64
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
$ facter os
{
  architecture => "x86_64",
  family => "RedHat",
  hardware => "x86_64",
  name => "RedHat",
  release => {
    full => "7.6",
    major => "7",
    minor => "6"
  },
  selinux => {
    enabled => false
  }
}
$ puppet module list
├── puppetlabs-apt (v6.2.1)
├── puppetlabs-docker (v3.2.0)
├── puppetlabs-powershell (v2.2.0)
├── puppetlabs-reboot (v2.0.0)
├── puppetlabs-stdlib (v5.1.0)
└── puppetlabs-translate (v1.1.0)
vchepkov added a commit to vchepkov/puppetlabs-docker that referenced this issue Feb 11, 2019
vchepkov added a commit to vchepkov/puppetlabs-docker that referenced this issue Feb 11, 2019
@davejrt davejrt added this to the 3.2.1 milestone Feb 13, 2019
@davejrt
Copy link
Contributor

davejrt commented Feb 13, 2019

closed by pr #423

@davejrt davejrt closed this as completed Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants