CLOUD-2146 cleanup of docker compose acceptance tests #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
sheenaajay
pushed a commit
that referenced
this pull request
Sep 27, 2018
florindragos
pushed a commit
that referenced
this pull request
Sep 27, 2018
* CLOUD-2146-cleanup-of-cocker-compose-acceptance-tests (#341) * pinning puppet version to fix failing spec tests
sheenaajay
pushed a commit
that referenced
this pull request
Sep 27, 2018
* adding in note about use of latest image tag * release prep for 3.0.0 (#342) * V3.0.0 release prep (#343) * release prep for 3.0.0 * Readme updates prior to release prep * Minor updates Minor updates * CLOUD-2146-cleanup-of-cocker-compose-acceptance-tests (#341) (#344) * pinning puppet version to fix failing spec tests (#346) * CLOUD-2146-cleanup-of-cocker-compose-acceptance-tests (#341) * pinning puppet version to fix failing spec tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to remove docker-compose tests for compose file versions prior to 3. The tests ran on each version are identical the only difference being the compose file version.Also docker_compose versions being tested were below minimum we support and windows was only supported in version3. Therefore it makes sense to reduce these as they are creating more overhead and not bringing increased value.