Check that docker_version is not nil before using it #770
Conversation
|
I added a fix for #771. I don’t know what @carabasdaniel tried to achieve in #759, but Facter::Core::Execution.exec is deprecated and doesn’t have a |
| value = Facter::Core::Execution.exec( | ||
| "#{docker_command} version --format '{{json .}}'", timeout: 90 | ||
| value = Facter::Core::Execution.execute( | ||
| "#{docker_command} version --format '{{json .}}'", options: {limit: 90} |
There was a problem hiding this comment.
Can someone who knows ruby confirm that this is how to do it? Whatever I pass as parameter to this function is accepted.
Also, while facter’s doc says the option is called time_limit, it seems to actually be called limit in the code.
There was a problem hiding this comment.
I guess the documentation is right and it's a bug in the code, I'll open a PR to address this :-)
There are a few more issues. I opened #773 to address them.
|
|
|
Hey @johanfleury, there seem to be some rubocop offenses. Could you please run kind regards, |
|
PR #773 supersede this one, I’ll close it. |
Fixes #769 and #771.