Defaults memory_limit to undef instead of ignored 0b value #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Realised that the typing of this key has changed from when I last forked it circa 2021 (and implemented this change) - this key is now optional and defaulting to the illegal 0b value. This will require a bit more change than a 1 liner. I will reopen when I have that implemented and tested |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
From #748 - sets the default
memory_limitsvalue toundefinstead of0b. As the Docker documentation states that0bis an impossible value to use - it appears to be ignoring the0bvalue. In which case this should not be a breaking change to any setup.Additional Context
Add any additional context about the problem here.
podmanusage as per the linked issueRelated Issues (if any)
#748
Checklist
puppet apply)