Skip to content

(MODULES-9895) iis_virtual_directory unable to create directories wit… #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

imaqsood
Copy link
Contributor

@imaqsood imaqsood commented Apr 4, 2025

Summary

This PR addresses MODULES-9895 — an issue where defining iis_virtual_directory resources with the same virtual path across multiple sites resulted in incorrect directory structures being created, such as:

Fix

The logic has been corrected to ensure virtual directories are created under the appropriate site path, without duplicating the site name in the directory structure. This allows the same virtual directory name (e.g., includes) to be used across multiple IIS sites without conflict.

Example

The following now behaves as expected:

iis_virtual_directory { "$site1/includes":
  ensure        => present,
  sitename      => $site1,
  physicalpath  => 'G:\inetpub\includes',
}

iis_virtual_directory { "$site2/includes":
  ensure        => present,
  sitename      => $site2,
  physicalpath  => 'G:\inetpub\includes',
}

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.

@imaqsood imaqsood requested a review from a team as a code owner April 4, 2025 06:02
@imaqsood imaqsood force-pushed the MODULES-9895 branch 29 times, most recently from ddc9da5 to 302186c Compare April 8, 2025 17:33
@imaqsood imaqsood force-pushed the MODULES-9895 branch 6 times, most recently from 6e632a6 to c6b7337 Compare April 9, 2025 19:52
Copy link
Contributor

@amitkarsale amitkarsale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imaqsood imaqsood merged commit 80fc3ce into puppetlabs:main Apr 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants