Skip to content

(FM-8971) allow deferred function for role pwd #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

tvpartytonight
Copy link
Contributor

No description provided.

@tvpartytonight tvpartytonight force-pushed the FM-8971 branch 3 times, most recently from 5dfb9c4 to f2b7f31 Compare July 14, 2022 21:57
This change allows the postgresql::server::role to accept a
deferred function for the $password_hash parameter. With
this change, the compiler can defer this sensitive value
to a deferred function that the agent applying the catalog
will execute.
@tvpartytonight tvpartytonight marked this pull request as ready for review July 14, 2022 23:11
@tvpartytonight tvpartytonight requested a review from a team as a code owner July 14, 2022 23:11
@chelnak
Copy link
Contributor

chelnak commented Jul 15, 2022

@tvpartytonight This looks great, thank you 😄.

@chelnak
Copy link
Contributor

chelnak commented Jul 15, 2022

@pmcmaw Can you review this too please?

@pmcmaw
Copy link
Contributor

pmcmaw commented Jul 15, 2022

@tvpartytonight agreed with @chelnak, looks great.
Appreciate the effort to get this over the line.

@pmcmaw pmcmaw added the feature label Jul 15, 2022
@chelnak
Copy link
Contributor

chelnak commented Jul 15, 2022

The SLES failures are not related to this PR so I'm tracking them in this issue.

@tvpartytonight tvpartytonight changed the title (FM-8971) WIP-allow deferred function for pwd (FM-8971) allow deferred function for role pwd Jul 15, 2022
@tvpartytonight tvpartytonight merged commit a8dbf8e into puppetlabs:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants