(MODULES-8717) Fix dependency issue on boltspec #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
approved these changes
Mar 5, 2019
|
Looks good although the dependency failure is a little concerning. |
|
Yeah it's odd that it's recently just cropped up out of no where - considering it's not just our modules that are affected and there has been no change I can manage to find to have caused it. There's no 'assert' method that can be found in BoltSpec that it claims to be conflicting on that I can find. For the meantime at least we have this solution 👍 Would someone else review this and get it merged please? Should hopefully help your CI pipeline out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the requires causing dependancy issues to the spec_helper_acceptance so they don't conflict with each other.