(MODULES-10963) remove win32-process on Puppet 7 #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puppet 7 dropped the dependecy on win32-process gem in favour of monkey patching the Process Module. As a reppercusion, require `win32/process` will no longer work on Puppet >= 7.0.0. This commit updates the reboot task to only require that specific gem if Puppet < 7.0.0
daianamezdrea
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet 7 dropped the dependency on win32-process gem
in favour of monkey patching the Process Module.
As a repercussion, require
win32/processwill nolonger work on Puppet >= 7.0.0.
This commit updates the reboot task to only require
that specific gem if Puppet < 7.0.0
Enabled and run the tests that were filtered out:
Tested manually on PE 2021.0.0 and the reboot task and plan can be run successfully