(MODULES-1638) Remove prompt parameter #62
Conversation
|
👍 /cc @cyberious |
|
Will test soon. But otherwise looks good to me. |
elyscape
force-pushed
the
remove_prompt
branch
from
d715467 to
7b81a68
Compare
|
I went ahead and rebased just in case that was helpful. |
|
Ping. Any update on this? |
elyscape
force-pushed
the
remove_prompt
branch
from
7b81a68 to
a670ba3
Compare
|
Rebased onto master. |
elyscape
force-pushed
the
remove_prompt
branch
from
a670ba3 to
5dba49d
Compare
|
Rebased again to take #66 into account. Pinging @joshcooper, @cyberious, @ferventcoder, and @hunner for review. |
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "puppetlabs-reboot", | |||
| "version": "0.1.10-SNAPSHOT", | |||
| "version": "0.2.0-SNAPSHOT", | |||
There was a problem hiding this comment.
Not sure what this change is here for
There was a problem hiding this comment.
This is a breaking change so I figured we should bump the non-patch version number. Honestly, I think once we merge this and #59, we should bump the version to 1.0.0.
|
Mostly +1, just a couple of thoughts. |
elyscape
force-pushed
the
remove_prompt
branch
from
5dba49d to
9bc9103
Compare
|
Pinging @joshcooper, @cyberious, @ferventcoder. Can we get some movement on this? |
|
Looks like this needs rebased and I think @cyberious is going to merge it with fire |
|
@elyscape please rebase and update Readme after |
|
@cyberious Done. |
(MODULES-1638) Remove prompt parameter
JIRA ticket here. This also bumps the version to 0.2.0-SNAPSHOT as it is a breaking change.