(PDB-5215) Don't crash on resources during sighup #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No reason --config <(echo something) shouldn't be allowed.
rbrw
force-pushed
the
pdb-5215-dont-crash-on-resources-during-sighup
branch
from
1f41032 to
8be4017
Compare
For now, just throw IllegalArgumentException to match the other config-related errors.
Don't need it, and since we'll need others, it'd be nice to avoid the clutter.
Allow jvm args so we can adjust the -cp, and then use it in all of the ext tests, both for consistency and so we're closer to the real runtime arrangement. run-all also made it look like that was already the case.
This can also be run this directly via ext/test/signal-handling after a "lein uberjar".
Right now, io/resource can crash if the current thread's context class loader is nil, which can sometimes be the case, and is the case with current puppetdb versions after startup and before processing any commands. Avoid the crash by falling back to the system class loader when the thread's is nil. cf. https://clojure.atlassian.net/browse/CLJ-2431 Thanks to Jérôme Charaoui for coming up with the reproduction that allowed tracking down the problem.
rbrw
force-pushed
the
pdb-5215-dont-crash-on-resources-during-sighup
branch
from
8be4017 to
a640031
Compare
austb
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.