Fix Backward Compatibility for servers running Pusher < 5.0.0 #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stejsi
approved these changes
May 18, 2022
sonologico
approved these changes
Jun 2, 2022
|
@Attia-Ahmed could this fix be included in branch "7.0.2" ? I need this version to be working because of this issue: beyondcode/laravel-websockets#1041 Thanks |
|
@Stejsi I have noticed that you have placed a thumbs-up on my request :) Could you tell me when the update will be done? We need this to be solved as soon as possible, otherwise we will have to configure another server..... Thanks in advance!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #322, calling
get_object_vars($result->channels)function inPusher.phpon response of old versions of pusher servers<v5.0.0lead toTypeErrorException, as anarrayis passed instead ofobject.CHANGELOG
get_object_vars()error on/src/Pusher.php