Skip to content

chore: remove PyPy 3.8 and 3.9 #5578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Mar 23, 2025

Description

Also make a pass through the entire repo to remove obviously obsolete workarounds for PyPy < 3.10.

This PR removes 6 GitHub Actions jobs, saving a total of 149 runner minutes per invocation of ci.yml:

  • CI / 🐍 pypy-3.8 • macos-13 • x64 (pull_request)Successful in 23m
  • CI / 🐍 pypy-3.8 • ubuntu-20.04 • x64 -DPYBIND11_FINDPYTHON=OFF (pull_request)Successful in 22m
  • CI / 🐍 pypy-3.8 • windows-2022 • x64 (pull_request)Successful in 30m
  • CI / 🐍 pypy-3.9 • macos-13 • x64 (pull_request)Successful in 24m
  • CI / 🐍 pypy-3.9 • ubuntu-20.04 • x64 (pull_request)Successful in 22m
  • CI / 🐍 pypy-3.9 • windows-2022 • x64 (pull_request)Successful in 28m

Suggested changelog entry:

Support for PyPy 3.8 and 3.9 was dropped.

…to remove obviously obsolete workarounds for PyPy < 3.10.
@rwgk rwgk marked this pull request as ready for review March 23, 2025 19:11
@rwgk rwgk requested a review from henryiii as a code owner March 23, 2025 19:11
@rwgk
Copy link
Collaborator Author

rwgk commented Mar 23, 2025

@henryiii Could you please review? Should only take a minute.

@mattip Does this look good to you?

@mattip
Copy link
Contributor

mattip commented Mar 23, 2025

Looks good to me

@rwgk
Copy link
Collaborator Author

rwgk commented Mar 24, 2025

Thanks!

@rwgk rwgk merged commit 48eb5ad into pybind:master Mar 24, 2025
74 checks passed
@rwgk rwgk deleted the remove_pypy_38_39_testing branch March 24, 2025 03:35
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Mar 24, 2025
@henryiii henryiii changed the title Remove PyPy 3.8 and 3.9 testing. chore: remove PyPy 3.8 and 3.9 Mar 31, 2025
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants