Skip to content

Allow accessing a connection's verfied certificate chain #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 5, 2020
Merged

Allow accessing a connection's verfied certificate chain #894

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2d0e4a6
Allow accessing a connection's verfied certificate chain
ShaneHarvey Mar 2, 2020
6851254
TLSv1_METHOD -> SSLv23_METHOD
ShaneHarvey Aug 5, 2020
263c08c
Use X509_up_ref instead of X509_dup
ShaneHarvey Aug 5, 2020
ba78fb2
Add _openssl_assert where appropriate
ShaneHarvey Aug 5, 2020
0e07516
SSL_get_peer_cert_chain should not be null
ShaneHarvey Aug 5, 2020
87f19e3
Reformat with black
ShaneHarvey Aug 5, 2020
6d11a89
Fix <OpenSSL.crypto.X509 object at 0x7fdbb59e8050> != <OpenSSL.crypto…
ShaneHarvey Aug 5, 2020
cc951ec
Add Changelog entry
ShaneHarvey Aug 5, 2020
63b0401
Remove _add_chain
ShaneHarvey Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix <OpenSSL.crypto.X509 object at 0x7fdbb59e8050> != <OpenSSL.crypto… 
….X509 object at 0x7fdbb59daad0>
  • Loading branch information
@ShaneHarvey
ShaneHarvey committed Aug 5, 2020
commit 6d11a89023e0a7ea37b0ac43ae1f6e1d45c59d9e
7 changes: 5 additions & 2 deletions tests/test_crypto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3864,8 +3864,11 @@ def test_get_verified_chain(self):
assert chain[1].get_subject() == self.intermediate_cert.get_subject()
assert chain[2].get_subject() == self.root_cert.get_subject()
# Test reuse
chain2 = store_ctx.get_verified_chain()
assert chain == chain2
chain = store_ctx.get_verified_chain()
assert len(chain) == 3
assert chain[0].get_subject() == intermediate_subject
assert chain[1].get_subject() == self.intermediate_cert.get_subject()
assert chain[2].get_subject() == self.root_cert.get_subject()

def test_get_verified_chain_invalid_chain_no_root(self):
"""
Expand Down