-
Notifications
You must be signed in to change notification settings - Fork 829
improve instrumentation docs #1625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR Change SummaryImproved the instrumentation documentation for Logfire, enhancing clarity and usability.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
Docs Preview
|
|
||
* **Debugging** — Using the live view to see what's happening in your application in real-time. | ||
* **Monitoring** — Using SQL and dashboards to observe the behavior of your application, Logfire is effectively a SQL database that stores information about how your application is running. | ||
|
||
### Debugging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The video here really needs updating
|
||
agent = Agent('openai:gpt-4o', instrument=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like you've removed all mentions of Agent(instrument=...)
which seems extreme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's still in the API docs.
from pydantic_ai.agent import Agent | ||
from pydantic_ai.models.instrumented import InstrumentationSettings | ||
|
||
os.environ['OTEL_EXPORTER_OTLP_ENDPOINT'] = 'http://localhost:4318' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand it might still be worth showing this this way, but I just want to point out that:
OTLPSpanExporter
uses that value by default anywayOTLPSpanExporter(endpoint=...)
can be used instead of an env var
Co-authored-by: Alex Hall <[email protected]>
No description provided.