Line scale()/scale_ip()
#170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzpr3d4t0r
requested changes
Jan 12, 2023
itzpr3d4t0r
reviewed
Jan 12, 2023
itzpr3d4t0r
reviewed
Jan 12, 2023
itzpr3d4t0r
reviewed
Jan 12, 2023
|
You have to add the new functions to geometry.rst as well |
itzpr3d4t0r
reviewed
Jan 13, 2023
itzpr3d4t0r
reviewed
Jan 13, 2023
itzpr3d4t0r
reviewed
Jan 13, 2023
itzpr3d4t0r
added
type:new_api
itzpr3d4t0r
reviewed
Jan 16, 2023
Comment on lines
+701
to
+714
| with self.assertRaises(ValueError): | ||
| line.scale_ip(0, 0.5) | ||
|
|
||
| with self.assertRaises(ValueError): | ||
| line.scale_ip(2, -0.1) | ||
|
|
||
| with self.assertRaises(ValueError): | ||
| line.scale_ip(-2, -0.5) | ||
|
|
||
| with self.assertRaises(ValueError): | ||
| line.scale_ip(17, 1.1) | ||
|
|
||
| with self.assertRaises(ValueError): | ||
| line.scale_ip(17, 10.0) |
There was a problem hiding this comment.
you could put these in a single for loop
itzpr3d4t0r
reviewed
Jan 16, 2023
itzpr3d4t0r
reviewed
Jan 16, 2023
|
|
||
| with self.assertRaises(ValueError): | ||
| line.scale_ip(17, 10.0) | ||
|
|
There was a problem hiding this comment.
You should also add tests for invalid argument type, here you just have invalid values, (scroll up and you'll find similar tests for argument types)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145