Fixed segfaults in poly __new__ and pgPolygon_FromObject #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves issue #171, and is a direct continuation of #157. The changes made include:
Polygon.__new__
function now always allocates memory for three vertices, meaning it creates a triangle. It's important to note that all vertices will have uninitialized data. It's a waste of performance to set all vertices to 0.__new__
allocated if more than three vertices need to be allocated.pgPolygon_FromObject
, moved around some*was_sequence = 1
s.pgPolygon_FromObject
to segfault when lists or tuples were passed as polygonsAnd The following program no longer segfaults: