Skip to content

Pin Python 3.11.0b1 [ci] #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Pin Python 3.11.0b1 [ci] #1560

wants to merge 1 commit into from

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented May 13, 2022

Description

Pin 3.11.0b1 for CI runs. Initially we added 3.11-dev as CI version. That helped a lot with addressing all open issues. However now that all have been fixed, it might be better to pin a specific beta / rc version. That way the CI pipeline can't break accidentally with the next update. We would have full control when we update and can address issues as they pop up.

The obvious downside of course is that version updates would be manual.

@cdce8p cdce8p added Discussion 🤔 Maintenance Discussion or action around maintaining astroid or the dev workflow labels May 13, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2322087346

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.807%

Totals Coverage Status
Change from base Build 2321941977: 0.0%
Covered Lines: 9189
Relevant Lines: 10009

💛 - Coveralls

@cdce8p
Copy link
Member Author

cdce8p commented May 13, 2022

Interesting 🤔

Python 3.11.0b1, Linux: 7:09min
Python 3.11.0b1, Windows: 0:33min

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the cleanup. I would prefer keeping -dev because I'm ready to merge failing pipeline if the issue is obviously only linked to 3.11, and because there's a balance to achieve between fixing 3.11.0-b1 only issues and having the pipeline break when a new release is out. I prefer the latter because we'll be fixing problem we'll still have in the end.

@cdce8p
Copy link
Member Author

cdce8p commented May 14, 2022

I would prefer keeping -dev because I'm ready to merge failing pipeline if the issue is obviously only linked to 3.11, and because there's a balance to achieve between fixing 3.11.0-b1 only issues and having the pipeline break when a new release is out. I prefer the latter because we'll be fixing problem we'll still have in the end.

It does make sense.

Python 3.11.0b1, Linux: 7:09min
Python 3.11.0b1, Windows: 0:33min

I tracked down the performance issue to coverage, or more specifically changes in 3.11 which make coverage slower. The increase for astroid already seems like a lot, but pylint will be much worse unfortunately. I really hope they can address it.

nedbat/coveragepy#1287 (comment)

--
I will close the PR for now. We can always do the cleanup later. The separation would allow us to exclude coverage for 3.11 and furthermore, the windows tests start up earlier since they don't have to wait for 3.11 to finish.

@cdce8p cdce8p closed this May 14, 2022
@cdce8p cdce8p deleted the pin-311 branch May 14, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion 🤔 Maintenance Discussion or action around maintaining astroid or the dev workflow python 3.11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants