Skip to content

Update pymc version requirements.txt #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024
Merged

Update pymc version requirements.txt #163

merged 1 commit into from
May 13, 2024

Conversation

juanitorduz
Copy link
Contributor

@juanitorduz juanitorduz commented May 13, 2024

@juanitorduz juanitorduz self-assigned this May 13, 2024
@juanitorduz juanitorduz added the maintenance Code style and repo configuration label May 13, 2024
@juanitorduz juanitorduz requested a review from aloctavodia May 13, 2024 15:40
@aloctavodia aloctavodia merged commit 3ca757f into main May 13, 2024
4 checks passed
@maresb
Copy link
Contributor

maresb commented May 14, 2024

Hard pinning pymc to 5.15.0 is pretty harsh, no? I'm not following closely, but is there a particular reason?

@juanitorduz juanitorduz deleted the pymc5_15 branch May 14, 2024 07:43
@juanitorduz
Copy link
Contributor Author

Hard pinning pymc to 5.15.0 is pretty harsh, no? I'm not following closely, but is there a particular reason?

Yes: see #162 (comment) (and initial scope of the PR)

@juanitorduz
Copy link
Contributor Author

@maresb, do you have a suggestion on how to handle this in a way to see if a new release breaks something and, if so, restrict the version?

@maresb
Copy link
Contributor

maresb commented May 14, 2024

I'd recommend a < pin to the next untested version, e.g. <5.15. Otherwise you won't be compatible with patch releases. Also, more broadly this prevents people from using it with previous versions. Is it incompatible with 5.13? If so, then it should be something like <=5.14,<5.15.

More broadly, we should do more testing.

@juanitorduz
Copy link
Contributor Author

ok! Let's see :) #164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code style and repo configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants