Skip to content

Deprecated data source used in "Getting Started With PyMC3" #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rodrigodesalvobraz opened this issue Nov 18, 2018 · 3 comments
Closed

Deprecated data source used in "Getting Started With PyMC3" #3262

rodrigodesalvobraz opened this issue Nov 18, 2018 · 3 comments
Labels
beginner friendly docs

Comments

@rodrigodesalvobraz
Copy link

Deprecated data source used in "Getting Started With PyMC3"

The tutorial uses pandas-datareader for reading financial data from Yahoo, but that is now deprecated:

From the pandas-datareader documentation:

"As of v0.6.0 Yahoo!, Google Options, Google Quotes and EDGAR have been immediately deprecated due to large changes in their API and no stable replacement. "

Obtaining the data still works, but now (Nov 18 2018) a NaN value is stored in the first position of the series and must be removed by hand. And of course the whole data may stop being provided any time, so you might want to modify the tutorial so that people remain able to run the example in the future.
@twiecki
Copy link
Member

twiecki commented Nov 26, 2018

Thanks, we should probably store the CSV file instead.

@ckrapu ckrapu mentioned this issue Dec 4, 2018
Merged
twiecki pushed a commit that referenced this issue Dec 5, 2018
@ckrapu @twiecki
Updated data file used for Getting Started and Profiling notebooks (#…
9906955 
…3262) (#3288)

* Updated data file used for Getting Started and Profiling notebooks

* Modified argument to parse_dates in Profiling and Getting Started notebooks

* Revert "Modified argument to parse_dates in Profiling and Getting Started notebooks"

This reverts commit 075c896.

* Updated installation instructions and get_data arguments in Getting Started and Profiling notebooks
@eigenfoo
Copy link
Member

@twiecki this PR is resolved by #3288, looks like we can close it 😃

@twiecki twiecki closed this as completed Dec 25, 2018
@twiecki
Copy link
Member

twiecki commented Dec 25, 2018

Thanks @eigenfoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@twiecki @rodrigodesalvobraz @eigenfoo