Skip to content

Some minor changes #2643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 23, 2017
Merged

Some minor changes #2643

merged 5 commits into from
Oct 23, 2017

Conversation

aseyboldt
Copy link
Member

  • More info about tune argument in pm.sample docstring
  • Cast metropolis scaling to double (ints lead to errors)
  • Use mean of lengths of grads instead of mean of squared grads in advi+adapt_diag_grad.

@fonnesbeck
Copy link
Member

Looks good. Merge when tests pass.

@aseyboldt
Copy link
Member Author

aseyboldt commented Oct 20, 2017

The change of adapt_diag_grad improves it enough so that I get better eff samples / s with it than using the usual adapt_diag (in the hierarchical_partial_pooling notebook).

@junpenglao
Copy link
Member

The change of adapt_diag_grad improves it enough so that I get better eff samples / s with it than using the usual adapt_diag (in the hierarchical_partial_pooling notebook).

We should put that into the benchmark models

@fonnesbeck
Copy link
Member

Also, perhaps populate RELEASE-NOTES with a line of information about the changes, as we discussed at the project meeting.

@twiecki
Copy link
Member

twiecki commented Oct 20, 2017

What's the reasoning behind the changes in adaption? Just works better empirically?

@aseyboldt
Copy link
Member Author

@twiecki Yes, I tried a couple of variants and this worked best. Also a bit of intuition, taking the mean of the inverse variances is a bit strange, it puts a lot of weight on very large values.

@junpenglao junpenglao merged commit f2b2645 into pymc-devs:master Oct 23, 2017
@junpenglao
Copy link
Member

Thanks @aseyboldt!

ColCarroll pushed a commit that referenced this pull request Nov 9, 2017
* Improve sample docstring

* Cast scaling in metropolis to double

* Update advi+adapt_diag_grad

* Update doc of nuts._Tree.extend

* Add adapt_diag_grad to release notes
@aseyboldt aseyboldt deleted the clearify-tuning branch February 11, 2018 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants