-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Some minor changes #2643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some minor changes #2643
Conversation
Looks good. Merge when tests pass. |
The change of |
We should put that into the benchmark models |
Also, perhaps populate RELEASE-NOTES with a line of information about the changes, as we discussed at the project meeting. |
What's the reasoning behind the changes in adaption? Just works better empirically? |
@twiecki Yes, I tried a couple of variants and this worked best. Also a bit of intuition, taking the mean of the inverse variances is a bit strange, it puts a lot of weight on very large values. |
Thanks @aseyboldt! |
* Improve sample docstring * Cast scaling in metropolis to double * Update advi+adapt_diag_grad * Update doc of nuts._Tree.extend * Add adapt_diag_grad to release notes
tune
argument inpm.sample
docstringadvi+adapt_diag_grad
.