SMC: work with transformed variables #2749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to merge once tests pass! One question, one comment: Question: Would it be easy to add a test (or update the test to use a transformed variable?) Comment: We allow 100 characters per line elsewhere in the project -- it looks like you were shooting for 80. Eighty is fine with me, but feel free to let the code breathe a little more if you want! |
|
Hi @ColCarroll ! I am seeing many errors that I did not see locally :-( I will have to check that. |
|
I think this is ready to merge, @ColCarroll? |
|
Nice work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #2742. Now SMC works with transformed, as well as not transformed variables.
I also made some PEP8-related changes.