Skip to content

DifferentialEquation Op refactor #3634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 3, 2019
Merged

DifferentialEquation Op refactor #3634

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
757937e
addition of test for equality checking of ODE Ops
michaelosthege Sep 25, 2019
82fdae8
WIP: refactoring the DifferentialEquation Op
michaelosthege Sep 25, 2019
d2040af
fully replace DifferentialEquation Op with the refactored implementation
michaelosthege Nov 1, 2019
4caeb4b
align tests with refactored API
michaelosthege Nov 1, 2019
0309fbe
use tt.stack as suggested by DeprecationWarning
michaelosthege Nov 1, 2019
33e3a33
always cast y0 and theta to floatX
michaelosthege Nov 1, 2019
5bed874
allow some tests to fail on float32
michaelosthege Nov 1, 2019
31dd2bf
don't use f-strings to maintain 3.5 support
michaelosthege Nov 1, 2019
e93cd93
link ODE refactor PR
michaelosthege Nov 1, 2019
bf4ae0b
renamed ODE notebooks
michaelosthege Nov 1, 2019
8172a83
Merge branch 'master' into ode-shapes-and-caching
michaelosthege Nov 1, 2019
5efc079
use (custom) errors instead of asserts
michaelosthege Nov 2, 2019
6bb988e
Merge branch 'ode-shapes-and-caching' of https://github.com/michaelos…
michaelosthege Nov 2, 2019
4359308
move ShapeError to exceptions.py
michaelosthege Nov 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
addition of test for equality checking of ODE Ops 
(not yet implemented)
  • Loading branch information
@michaelosthege
michaelosthege committed Sep 25, 2019
commit 757937e4817a0f49199cd79956be7082bb1c7aa6
4 changes: 4 additions & 0 deletions pymc3/tests/test_ode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,10 @@ def test_number_of_params(self):
condition=(theano.config.floatX == "float32"), reason="Fails on float32"
)
class TestDiffEqModel(object):
def test_op_equality(self):
raise NotImplementedError()
return

def test_scalar_ode_1_param(self):
"""Test running model for a scalar ODE with 1 parameter"""

Expand Down