Skip to content

Fix issue 3793 #3843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 20, 2020
Merged

Fix issue 3793 #3843

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
446557c
Demonstrate issue 3793.
rpgoldman Mar 19, 2020
7254d3e
Give Data model-relative names.
rpgoldman Mar 19, 2020
67ce55c
Move test description into docstring
michaelosthege Mar 20, 2020
0c6e133
mention changes to pm.Data naming
michaelosthege Mar 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move test description into docstring
  • Loading branch information
@michaelosthege
michaelosthege authored Mar 20, 2020
commit 67ce55c60f9c2c611a75953209fcf96574db8fbb
7 changes: 5 additions & 2 deletions pymc3/tests/test_data_container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,12 @@ def test_model_to_graphviz_for_model_with_data_container(self):
text = 'obs [label="obs ~ Normal" style=filled]'
assert text in g.source

# this is a test for issue 3793 -- `Data` objects in named models are
# not given model-relative names.

def test_data_naming():
"""
This is a test for issue #3793 -- `Data` objects in named models are
not given model-relative names.
"""
with pm.Model("named_model") as model:
x = pm.Data("x", [1.0, 2.0, 3.0])
y = pm.Normal("y")
Expand Down