Skip to content

Expand pm.Data capacities #3925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 18, 2020
Merged

Expand pm.Data capacities #3925

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
05462f2
Initial changes to allow pymc3.Data() to support both int and float i…
hottwaj Feb 26, 2020
0041e9f
added exception for invalid dtype input to pandas_to_array
hottwaj Feb 26, 2020
2535738
Merge branch 'add-dtype-to-data' of https://github.com/hottwaj/pymc3 …
AlexAndorra May 17, 2020
38536aa
Refined implementation
AlexAndorra May 17, 2020
08b3ba4
Finished dtype conversion handling
AlexAndorra May 17, 2020
1fd0e8b
Added SharedVariable option to getattr_value
AlexAndorra May 17, 2020
766285c
Added dtype handling to set_data function
AlexAndorra May 17, 2020
63132e7
Added tests for pm.Data used for index variables
AlexAndorra May 17, 2020
1bd8642
Added tests for using pm.data as RV input
AlexAndorra May 17, 2020
6597f28
Ran Black on data tests files
AlexAndorra May 17, 2020
b3a9dee
Added release note
AlexAndorra May 17, 2020
5e5440c
Updated release notes
AlexAndorra May 18, 2020
0d07347
Updated code in light of Luciano's comments
AlexAndorra May 18, 2020
41200ef
Fixed implementation of integer checking
AlexAndorra May 18, 2020
7c359d8
Simplified implementation of type checking
AlexAndorra May 18, 2020
f7bf6db
Corrected implementation for other uses of pandas_to_array
AlexAndorra May 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated release notes
  • Loading branch information
@AlexAndorra
AlexAndorra committed May 18, 2020
commit 5e5440c1e0b41630b9cc82c9d6de90f73c8254f6
4 changes: 2 additions & 2 deletions RELEASE-NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
- `pm.sample` now has support for adapting dense mass matrix using `QuadPotentialFullAdapt` (see [#3596](https://github.com/pymc-devs/pymc3/pull/3596), [#3705](https://github.com/pymc-devs/pymc3/pull/3705), [#3858](https://github.com/pymc-devs/pymc3/pull/3858), and [#3893](https://github.com/pymc-devs/pymc3/pull/3893)). Use `init="adapt_full"` or `init="jitter+adapt_full"` to use.
- `Moyal` distribution added (see [#3870](https://github.com/pymc-devs/pymc3/pull/3870)).
- `pm.LKJCholeskyCov` now automatically computes and returns the unpacked Cholesky decomposition, the correlations and the standard deviations of the covariance matrix (see [#3881](https://github.com/pymc-devs/pymc3/pull/3881)).
- `pm.Data` container can now be used for index variables, i.e with integer data and not only floats (see [#3925](https://github.com/pymc-devs/pymc3/pull/3925)).
- `pm.Data` container can now be used as input for other random variables (see [#3925](https://github.com/pymc-devs/pymc3/pull/3925)).
- `pm.Data` container can now be used for index variables, i.e with integer data and not only floats (issue [#3813](https://github.com/pymc-devs/pymc3/issues/3813), fixed by [#3925](https://github.com/pymc-devs/pymc3/pull/3925)).
- `pm.Data` container can now be used as input for other random variables (issue [#3842](https://github.com/pymc-devs/pymc3/issues/3842), fixed by [#3925](https://github.com/pymc-devs/pymc3/pull/3925)).

### Maintenance
- Tuning results no longer leak into sequentially sampled `Metropolis` chains (see #3733 and #3796).
Expand Down