Skip to content

Implement and switch to lazy initval evaluation framework #4983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 14, 2021
Merged

Implement and switch to lazy initval evaluation framework #4983

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
eff7e60
Update aesara dependency version
ricardoV94 Oct 12, 2021
d2bb41c
Evaluate initial values lazily
michaelosthege Sep 4, 2021
bf26f86
Manage initial values by RV var instead of RV value var
michaelosthege Sep 21, 2021
5ad9fa8
Stop caching initial points and wrap function creation
michaelosthege Sep 21, 2021
e83e3cb
Switch from test_value to "moment"/"prior" based initvals
michaelosthege Sep 21, 2021
daa8672
Implement aesara function that computes all the initial values of a m…
aseyboldt Sep 21, 2021
816c31d
Deprecate Model.update_start_vals method
michaelosthege Sep 24, 2021
da05ab4
Skip test_init_jitter
ricardoV94 Oct 11, 2021
6d678f4
Remove XFAIL mark on passing tests
michaelosthege Sep 29, 2021
ff3b7f7
XFAIL tests that depend on #5007
michaelosthege Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
XFAIL tests that depend on #5007 
To unblock this PR/branch from the aeppl integration.
  • Loading branch information
@michaelosthege @ricardoV94
michaelosthege authored and ricardoV94 committed Oct 14, 2021
commit ff3b7f76e9600a85bb3b020843880716125f772a
12 changes: 12 additions & 0 deletions pymc/tests/test_ndarray_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,9 @@ def setup_class(cls):
with TestSaveLoad.model():
cls.trace = pm.sample(return_inferencedata=False)

@pytest.mark.xfail(
reason="Needs aeppl integration due to unintentional model graph rewrite #5007."
)
def test_save_new_model(self, tmpdir_factory):
directory = str(tmpdir_factory.mktemp("data"))
save_dir = pm.save_trace(self.trace, directory, overwrite=True)
Expand All @@ -239,6 +242,9 @@ def test_save_new_model(self, tmpdir_factory):

assert (new_trace["w"] == new_trace_copy["w"]).all()

@pytest.mark.xfail(
reason="Needs aeppl integration due to unintentional model graph rewrite #5007."
)
def test_save_and_load(self, tmpdir_factory):
directory = str(tmpdir_factory.mktemp("data"))
save_dir = pm.save_trace(self.trace, directory, overwrite=True)
Expand All @@ -256,11 +262,17 @@ def test_save_and_load(self, tmpdir_factory):
"Restored value of statistic %s does not match stored value" % stat
)

@pytest.mark.xfail(
reason="Needs aeppl integration due to unintentional model graph rewrite #5007."
)
def test_bad_load(self, tmpdir_factory):
directory = str(tmpdir_factory.mktemp("data"))
with pytest.raises(pm.TraceDirectoryError):
pm.load_trace(directory, model=TestSaveLoad.model())

@pytest.mark.xfail(
reason="Needs aeppl integration due to unintentional model graph rewrite #5007."
)
def test_sample_posterior_predictive(self, tmpdir_factory):
directory = str(tmpdir_factory.mktemp("data"))
save_dir = pm.save_trace(self.trace, directory, overwrite=True)
Expand Down