Skip to content

Rename basic "joint_logprob" functions to "conditional_logp" #6760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented Jun 7, 2023

It only becomes a "joint_logp" after the terms are summed


📚 Documentation preview 📚: https://pymc--6760.org.readthedocs.build/en/6760/

@ricardoV94 ricardoV94 added maintenance logprob major Include in major changes release notes section labels Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #6760 (2a9f2b7) into main (a32c5e7) will decrease coverage by 12.75%.
The diff coverage is 73.33%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6760       +/-   ##
===========================================
- Coverage   91.93%   79.19%   -12.75%     
===========================================
  Files          95       95               
  Lines       16128    16134        +6     
===========================================
- Hits        14828    12777     -2051     
- Misses       1300     3357     +2057     
Impacted Files Coverage Δ
pymc/logprob/basic.py 96.85% <55.55%> (-3.15%) ⬇️
pymc/logprob/__init__.py 100.00% <100.00%> (ø)
pymc/logprob/scan.py 98.49% <100.00%> (ø)
pymc/model.py 89.29% <100.00%> (-0.62%) ⬇️
pymc/testing.py 37.99% <100.00%> (-53.62%) ⬇️

... and 33 files with indirect coverage changes

@ricardoV94 ricardoV94 requested a review from canyon289 June 7, 2023 19:02
@twiecki
Copy link
Member

twiecki commented Jun 7, 2023

But is it truly a conditional logp? Conditional on what?

@ricardoV94
Copy link
Member Author

ricardoV94 commented Jun 7, 2023

But is it truly a conditional logp? Conditional on what?

Conditional on all the other valued rvs. If you have vars [x, y, z], this can give you [p(x|y,z), p(y|x,z), p(z|x,y)]

Of course some terms drop out because we always work with DAGs

@ricardoV94 ricardoV94 marked this pull request as draft June 8, 2023 05:58
@ricardoV94 ricardoV94 force-pushed the rename_joint_logprob branch from 2354bf7 to e618129 Compare June 8, 2023 07:50
@ricardoV94 ricardoV94 marked this pull request as ready for review June 8, 2023 07:54
@ricardoV94
Copy link
Member Author

Removed a couple more references to factorized that were still around. I'll merge if the docstrings render correctly

@ricardoV94 ricardoV94 force-pushed the rename_joint_logprob branch from e618129 to 2a9f2b7 Compare June 8, 2023 07:57
@ricardoV94 ricardoV94 merged commit 2ac88af into pymc-devs:main Jun 8, 2023
@ricardoV94 ricardoV94 deleted the rename_joint_logprob branch September 18, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logprob maintenance major Include in major changes release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants