You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#2529 added a call to await asyncio.sleep(0.1) to the connect method of ModbusBaseClient. This is causing a significant increase in the time it takes to run the test suite for an application that creates a new server and client in each test (+1 second per 10 tests). Is there a reason for this line or was it left over from some debugging?
Yes there is a reason, it was not stable without it, due to task scheduling. And compared to the actual connection time 0,1 second is not very relevant.
The pymodbus have 1000+ test cases, and a lot of them with a server involved, and still running all takes around 3 minutes.
Anyhow if you want changes, then pull requests are welcome.
#2529 added a call to
await asyncio.sleep(0.1)
to theconnect
method ofModbusBaseClient
. This is causing a significant increase in the time it takes to run the test suite for an application that creates a new server and client in each test (+1 second per 10 tests). Is there a reason for this line or was it left over from some debugging?https://github.com/pymodbus-dev/pymodbus/pull/2529/files#diff-a3d2fee1960ff928b8c5a01044d31ce619ecc6073db11c3aac8734737a8afc0fR62
The text was updated successfully, but these errors were encountered: